Trap errors in callbacks #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
added a commit
to CrossStream/node-htu21d
that referenced
this pull request
Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a Origin: https://github.com/CrossStream/node-htu21d/ Forwarded: bbx10#4 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/node/review/master
branch
from
d640c3f to
d6a6149
Compare
rzr
added a commit
to CrossStream/node-htu21d
that referenced
this pull request
Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a Origin: https://github.com/CrossStream/node-htu21d/ Forwarded: bbx10#4 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/node/review/master
branch
from
d6a6149 to
2a911ba
Compare
rzr
added a commit
to CrossStream/node-htu21d
that referenced
this pull request
Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a Origin: https://github.com/CrossStream/node-htu21d/ Forwarded: bbx10#4 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
added a commit
to CrossStream/node-htu21d
that referenced
this pull request
Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a Origin: https://github.com/CrossStream/node-htu21d/ Forwarded: bbx10#4 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/node/review/master
branch
from
2a911ba to
af2f6e4
Compare
rzr
added a commit
to CrossStream/node-htu21d
that referenced
this pull request
Jan 17, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a Origin: https://github.com/CrossStream/node-htu21d/ Forwarded: bbx10#4 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/node/review/master
branch
from
af2f6e4 to
1a2d54d
Compare
rzr
commented
Jan 21, 2020
There was a problem hiding this comment.
Please consider merging this change it was tested by @dror3go
I plan to pull it in next version of:
|
Looks good, and I can confirm that this is working. cc @bbx10 |
This was referenced Jan 28, 2020
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a Origin: https://github.com/CrossStream/node-htu21d/ Forwarded: bbx10#4 Signed-off-by: Philippe Coval <rzr@users.sf.net>
Change-Id: I6457129c7fbd1504d1c476f9079f64115b7c917b Origin: https://github.com/CrossStream/node-htu21d/ Forwarded: bbx10#4 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/node/review/master
branch
from
1a2d54d to
38ea93c
Compare
|
This change has been released in: |
|
Please feedback welcome on this PR If this package is no more maintained may you consider to transfer it to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I824f17b2a6b921535cf8772995fabb40d06d765a
Origin: https://github.com/CrossStream/node-htu21d/
Forwarded: https://github.com/bbx10/node-htu21d/pulls
Signed-off-by: Philippe Coval rzr@users.sf.net